THRIFT-5922: made http header lookup case insensitive#3328
Merged
Jens-G merged 1 commit intoapache:masterfrom Mar 5, 2026
Merged
THRIFT-5922: made http header lookup case insensitive#3328Jens-G merged 1 commit intoapache:masterfrom
Jens-G merged 1 commit intoapache:masterfrom
Conversation
Member
| for key, val in string.gmatch(line, "([%w%-]+)%s*:%s*(.+)") do | ||
| if headers[key] then | ||
| local delimiter = ", " | ||
| if key == "Set-Cookie" then |
Contributor
There was a problem hiding this comment.
should this line also be comparing lowercase?
now all headers are stored lower but this check is case sensitive
Contributor
Author
There was a problem hiding this comment.
Yes definitely! I must have missed it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client: lua
The http transport client breaks when the traffic is routed through a proxy that changes the casing of the header keys. This is not only incorrect but also different from the implementation in all other languages.
This pull request changes this, so http headers are now stored/retrieved in a case insensitive matter.
Since there are no unit tests for lua (that i could find?) I did not add tests that isolate this bug, but it's quite obvious from looking at the source.
[skip ci]anywhere in the commit message to free up build resources.